Skip uv compile step for URL-based dependencies in add command

[cnpryer]

Drafting this PR to follow up on #800 debug.

This PR updates the add command to avoid passing URL-based dependencies to uv compile in rye add command.

Testing: Manual + Snapshots

[cnpryer]

I wanted to look into why the requirement with a url would need to make a trip through uv to begin with. I'm sure I'm forgetting something obvious, but this at least demonstrates where the issue might be coming from.

[cnpryer]

See comment

[bluss]

As the code is here, you skip using the result from uv for URLs and that makes sense (If I understand the code correctly) - but should we then also skip using uv at all? I don't know if it's important for the add command do some kind of validation of the arguments like this (checking that they exist)

Edit: ok see now, the command is not spawned in the URL case. So it's already skipping. Seems good to me, but I'm not sure if there are other reasons like I said.

[cnpryer]

Yup we seem to be on the same page. Initially it seems like we can just skip it since these are direct references, but I want to understand the big picture a little better.

Thanks for looking at this!

[cnpryer]

I believe this was expected, but I tried recreating this issue as a uv tests since there are stdin tests over there for pip compile. So far I can't reproduce it.

/// Resolve with PROJECT_ROOT path from a `requirements.in` file on stdin when
/// passed a path of `-`.
#[test]
fn compile_requirements_in_stdin_path() -> Result<()> {
    let context = TestContext::new("3.12");
    let requirements_in = context.temp_dir.child("requirements.in");
    requirements_in.write_str("maturin_editable @ file:///${PROJECT_ROOT}/../../scripts/editable-installs/maturin_editable")?;

    uv_snapshot!(Command::new(get_bin())
    .arg("pip")
    .arg("compile")
    .stdin(fs::File::open(requirements_in)?)
    .arg("-"), @r###"
    success: true
    exit_code: 0
    ----- stdout -----
    # This file was autogenerated by uv via the following command:
    #    uv pip compile -
    maturin-editable @ file:///${PROJECT_ROOT}/../../scripts/editable-installs/maturin_editable

    ----- stderr -----
    Resolved 1 package in [TIME]
    "###);

    Ok(())
}

[cnpryer]

I'd like to read into URL-based dependencies more before marking this as ready.

In the meantime I'll share my thoughts so far. Since URL-based dependencies are direct references, I'd assume that uv would always emit the same requirements string each time. So if that's the case, I'd think doing this here, where we are just skipping that trip for URL-based dependencies, could work.

I'll give it some more thought.

[cnpryer]

I'll mark this as ready, but I want to go and review some issues that have been submitted. I think there might be a few this can either begin to address or close completely.

[charliermarsh]

Could this be simplified to just:

if matches!(req.version_or_url, Some(VersionOrUrl::Url(_))) {
    continue;
}

At the very top of the loop (line 452)?

[cnpryer]

Ty. Spotted that last night and forgot to do it.

[cnpryer]

A little premature to mark as ready. I need to tweak this, add a --git test, and tag some related issues.

This might warrant a CHANGELOG entry as well.