Rename rye-test-home to rye-test-dir #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnpryer
force-pushed
the
chore-test-dir
branch
from
27c07fb to
1f6c833
Compare
cnpryer
force-pushed
the
chore-test-dir
branch
from
1f6c833 to
3458654
Compare
mitsuhiko
requested changes
Feb 26, 2024
rye/tests/common/mod.rs
Outdated
| @@ -17,7 +17,7 @@ pub const INSTA_FILTERS: &[(&str, &str)] = &[ | |||
| "[TEMP_PATH]/", | |||
| ), | |||
| // home | |||
| (r"(\b[A-Z]:)?[\\/].*?[\\/]rye-test-home", "[RYE_HOME]"), | |||
| (r"(\b[A-Z]:)?[\\/].*?[\\/]home", "[RYE_HOME]"), | |||
There was a problem hiding this comment.
Too many false positives. Maybe change to rye-test-dir[\\/]home?
cnpryer
force-pushed
the
chore-test-dir
branch
from
80d3ba1 to
1802e19
Compare
cnpryer
force-pushed
the
chore-test-dir
branch
from
1802e19 to
4605add
Compare
cnpryer
commented
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #759 I'd like to add a wheels directory as part of the testing resources we're storing in target/debug/rye-test-home.
I've changed RYE_HOME to rye-test-dir/home. I'd add rye-test-dir/wheels in #759.