Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve author detection when includeIf is used #443

Merged
merged 5 commits into from
Sep 8, 2023

Conversation

CharlesChen0823
Copy link
Contributor

@CharlesChen0823 CharlesChen0823 commented Sep 7, 2023

currently, rye cannot get correctly user.(email|name) from .gitconfig which using includeIf in the file. This PR is to fix this problem. closes #435

@mitsuhiko mitsuhiko changed the title Fix 435 Improve author detection when includeIf is used Sep 8, 2023
@mitsuhiko mitsuhiko merged commit 2f0c709 into astral-sh:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not get git user.email value if defined within an includeif gitconfig file
2 participants