-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where output format mode would not change to full
if preview mode was set in configuration file
#9763
Conversation
63c69ed
to
dda469e
Compare
cc @AlexWaygood |
I think the added test also passes on the |
|
Really? That doesn't make sense to me. We should try to have a regression test. |
Going to merge so we can move forward with the release. We should investigate more separately. |
Thanks for the quick fix @snowsignal! :D |
Summary
This was causing build failures for #9599. We were referencing the command line overrides instead of the merged configuration data, hence the issue.
Test Plan
A snapshot test was added.