Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add autofix for PYI030" #7943

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Revert "add autofix for PYI030" #7943

merged 1 commit into from
Oct 13, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Oct 13, 2023

This reverts commit #7880 (d8c0360) which does not perform the correct fix per #7934

@zanieb zanieb changed the title Revert "add autofix for PYI030 (#7880)" Revert "add autofix for PYI030" Oct 13, 2023
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+6, -6, 0 error(s))

airflow (+4, -4)

+ [*] 16069 fixable with the `--fix` option (6167 hidden fixes can be enabled with the `--unsafe-fixes` option).
- [*] 16072 fixable with the `--fix` option (6167 hidden fixes can be enabled with the `--unsafe-fixes` option).
+ airflow/cli/commands/task_command.py:80:21: PYI030 Multiple literal members in a union. Use a single literal, e.g. `Literal[False, "db", "memory"]`
- airflow/cli/commands/task_command.py:80:21: PYI030 [*] Multiple literal members in a union. Use a single literal, e.g. `Literal[False, "db", "memory"]`
+ airflow/models/mappedoperator.py:85:20: PYI030 Multiple literal members in a union. Use a single literal, e.g. `Literal["expand", "partial"]`
- airflow/models/mappedoperator.py:85:20: PYI030 [*] Multiple literal members in a union. Use a single literal, e.g. `Literal["expand", "partial"]`
+ airflow/providers_manager.py:195:24: PYI030 Multiple literal members in a union. Use a single literal, e.g. `Literal["source", "package"]`
- airflow/providers_manager.py:195:24: PYI030 [*] Multiple literal members in a union. Use a single literal, e.g. `Literal["source", "package"]`

bokeh (+2, -2)

+ [*] 17800 fixable with the `--fix` option (4369 hidden fixes can be enabled with the `--unsafe-fixes` option).
- [*] 17801 fixable with the `--fix` option (4369 hidden fixes can be enabled with the `--unsafe-fixes` option).
+ src/bokeh/core/serialization.py:149:25: PYI030 Multiple literal members in a union. Use a single literal, e.g. `Literal["bool", "object"]`
- src/bokeh/core/serialization.py:149:25: PYI030 [*] Multiple literal members in a union. Use a single literal, e.g. `Literal["bool", "object"]`

Rules changed: 1
Rule Changes Additions Removals
PYI030 8 4 4

@zanieb zanieb merged commit 8255e4e into main Oct 13, 2023
@zanieb zanieb deleted the revert/7880 branch October 13, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant