Promote some rules to "always" fixable #7840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+3033, -3059, 0 error(s)) disnake (+6, -6)
- 5 hidden fixes can be enabled with the `--unsafe-fixes` option. + [*] 5 fixable with the `--fix` option. - disnake/enums.py:756:30: RUF100 Unused `noqa` directive (unused: `RUF001`) + disnake/enums.py:756:30: RUF100 [*] Unused `noqa` directive (unused: `RUF001`) - disnake/enums.py:764:25: RUF100 Unused `noqa` directive (unused: `RUF001`) + disnake/enums.py:764:25: RUF100 [*] Unused `noqa` directive (unused: `RUF001`) - disnake/enums.py:810:31: RUF100 Unused `noqa` directive (unused: `RUF001`) + disnake/enums.py:810:31: RUF100 [*] Unused `noqa` directive (unused: `RUF001`) - disnake/opus.py:237:47: RUF100 Unused `noqa` directive (unused: `PLW0603`) + disnake/opus.py:237:47: RUF100 [*] Unused `noqa` directive (unused: `PLW0603`) - disnake/opus.py:242:42: RUF100 Unused `noqa` directive (unused: `PLW0603`) + disnake/opus.py:242:42: RUF100 [*] Unused `noqa` directive (unused: `PLW0603`) rasa (+22, -22)
- [*] 108 fixable with the `--fix` option (47 hidden fixes can be enabled with the `--unsafe-fixes` option). + [*] 129 fixable with the `--fix` option (26 hidden fixes can be enabled with the `--unsafe-fixes` option). - rasa/api.py:143:95: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/api.py:143:95: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/api.py:144:95: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/api.py:144:95: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/core/actions/action.py:1026:101: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/core/actions/action.py:1026:101: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/core/actions/action.py:952:95: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/core/actions/action.py:952:95: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/core/actions/two_stage_fallback.py:184:105: RUF100 Unused blanket `noqa` directive + rasa/core/actions/two_stage_fallback.py:184:105: RUF100 [*] Unused blanket `noqa` directive - rasa/core/agent.py:422:93: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/core/agent.py:422:93: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/core/featurizers/single_state_featurizer.py:119:97: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/core/featurizers/single_state_featurizer.py:119:97: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/core/test.py:301:92: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/core/test.py:301:92: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/core/test.py:308:92: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/core/test.py:308:92: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/core/test.py:462:97: RUF100 Unused blanket `noqa` directive + rasa/core/test.py:462:97: RUF100 [*] Unused blanket `noqa` directive - rasa/nlu/extractors/crf_entity_extractor.py:111:89: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/nlu/extractors/crf_entity_extractor.py:111:89: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/nlu/utils/hugging_face/registry.py:28:77: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/nlu/utils/hugging_face/registry.py:28:77: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/shared/core/events.py:88:109: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/shared/core/events.py:88:109: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/shared/core/slots.py:301:95: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/shared/core/slots.py:301:95: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/shared/core/trackers.py:278:111: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/shared/core/trackers.py:278:111: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/shared/core/training_data/story_writer/yaml_story_writer.py:220:107: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/shared/core/training_data/story_writer/yaml_story_writer.py:220:107: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/shared/core/training_data/visualization.py:454:111: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/shared/core/training_data/visualization.py:454:111: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/shared/nlu/training_data/entities_parser.py:27:145: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/shared/nlu/training_data/entities_parser.py:27:145: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/utils/endpoints.py:23:82: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/utils/endpoints.py:23:82: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/utils/tensorflow/data_generator.py:220:97: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/utils/tensorflow/data_generator.py:220:97: RUF100 [*] Unused `noqa` directive (unused: `E501`) - rasa/utils/tensorflow/model_data.py:106:108: RUF100 Unused `noqa` directive (unused: `E501`) + rasa/utils/tensorflow/model_data.py:106:108: RUF100 [*] Unused `noqa` directive (unused: `E501`) airflow (+165, -165)
- [*] 15845 fixable with the `--fix` option (6478 hidden fixes can be enabled with the `--unsafe-fixes` option). + [*] 16009 fixable with the `--fix` option (6314 hidden fixes can be enabled with the `--unsafe-fixes` option). - airflow/cli/commands/task_command.py:304:16: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/cli/commands/task_command.py:304:16: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/decorators/base.py:519:9: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + airflow/decorators/base.py:519:9: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - airflow/decorators/base.py:520:9: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + airflow/decorators/base.py:520:9: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - airflow/decorators/base.py:521:9: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + airflow/decorators/base.py:521:9: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - airflow/models/db_callback_request.py:56:21: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/models/db_callback_request.py:56:21: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/models/taskinstance.py:1014:16: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/models/taskinstance.py:1014:16: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/providers/airbyte/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/airbyte/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/alibaba/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/alibaba/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/amazon/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/amazon/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/beam/__init__.py:42:109: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/beam/__init__.py:42:109: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/drill/__init__.py:42:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/drill/__init__.py:42:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/druid/__init__.py:42:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/druid/__init__.py:42:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/flink/__init__.py:42:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/flink/__init__.py:42:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/hdfs/__init__.py:42:109: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/hdfs/__init__.py:42:109: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/hive/__init__.py:42:109: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/hive/__init__.py:42:109: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/impala/__init__.py:42:111: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/impala/__init__.py:42:111: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/kafka/__init__.py:40:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/kafka/__init__.py:40:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/kylin/__init__.py:40:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/kylin/__init__.py:40:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/livy/__init__.py:42:109: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/livy/__init__.py:42:109: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/pig/__init__.py:42:108: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/pig/__init__.py:42:108: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/pinot/__init__.py:42:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/pinot/__init__.py:42:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/spark/__init__.py:42:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/spark/__init__.py:42:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apache/sqoop/__init__.py:42:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apache/sqoop/__init__.py:42:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/apprise/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/apprise/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/arangodb/__init__.py:42:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/arangodb/__init__.py:42:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/asana/__init__.py:42:103: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/asana/__init__.py:42:103: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/atlassian/jira/__init__.py:40:112: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/atlassian/jira/__init__.py:40:112: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/celery/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/celery/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/cloudant/__init__.py:40:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/cloudant/__init__.py:40:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/cncf/kubernetes/__init__.py:42:113: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/cncf/kubernetes/__init__.py:42:113: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/common/sql/__init__.py:42:108: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/common/sql/__init__.py:42:108: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/daskexecutor/__init__.py:42:110: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/daskexecutor/__init__.py:42:110: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/databricks/__init__.py:42:108: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/databricks/__init__.py:42:108: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/datadog/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/datadog/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/dbt/cloud/__init__.py:42:107: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/dbt/cloud/__init__.py:42:107: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/dingding/__init__.py:40:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/dingding/__init__.py:40:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/discord/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/discord/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/docker/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/docker/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/elasticsearch/__init__.py:42:111: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/elasticsearch/__init__.py:42:111: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/exasol/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/exasol/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/facebook/__init__.py:42:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/facebook/__init__.py:42:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/ftp/__init__.py:42:101: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/ftp/__init__.py:42:101: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/github/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/github/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/google/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/google/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/google/cloud/hooks/cloud_sql.py:1011:20: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/providers/google/cloud/hooks/cloud_sql.py:1011:20: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/providers/google/cloud/hooks/vision.py:87:25: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/providers/google/cloud/hooks/vision.py:87:25: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/providers/grpc/__init__.py:42:102: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/grpc/__init__.py:42:102: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/hashicorp/__init__.py:42:107: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/hashicorp/__init__.py:42:107: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/http/__init__.py:42:102: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/http/__init__.py:42:102: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/imap/__init__.py:42:102: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/imap/__init__.py:42:102: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/influxdb/__init__.py:42:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/influxdb/__init__.py:42:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/jdbc/__init__.py:42:102: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/jdbc/__init__.py:42:102: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/jenkins/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/jenkins/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/microsoft/azure/__init__.py:42:113: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/microsoft/azure/__init__.py:42:113: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/microsoft/mssql/__init__.py:42:113: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/microsoft/mssql/__init__.py:42:113: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/microsoft/psrp/__init__.py:42:112: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/microsoft/psrp/__init__.py:42:112: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/microsoft/winrm/__init__.py:42:113: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/microsoft/winrm/__init__.py:42:113: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/mongo/__init__.py:42:103: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/mongo/__init__.py:42:103: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/mysql/__init__.py:42:103: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/mysql/__init__.py:42:103: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/neo4j/__init__.py:42:103: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/neo4j/__init__.py:42:103: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/odbc/__init__.py:40:102: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/odbc/__init__.py:40:102: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/openfaas/__init__.py:40:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/openfaas/__init__.py:40:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/openlineage/__init__.py:42:109: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/openlineage/__init__.py:42:109: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/openlineage/utils/utils.py:148:48: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/providers/openlineage/utils/utils.py:148:48: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/providers/openlineage/utils/utils.py:250:41: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/providers/openlineage/utils/utils.py:250:41: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/providers/opsgenie/__init__.py:40:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/opsgenie/__init__.py:40:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/oracle/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/oracle/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/pagerduty/__init__.py:42:107: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/pagerduty/__init__.py:42:107: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/papermill/__init__.py:40:107: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/papermill/__init__.py:40:107: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/plexus/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/plexus/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/postgres/__init__.py:42:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/postgres/__init__.py:42:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/presto/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/presto/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/qubole/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/qubole/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/redis/__init__.py:42:103: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/redis/__init__.py:42:103: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/salesforce/__init__.py:42:108: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/salesforce/__init__.py:42:108: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/samba/__init__.py:42:103: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/samba/__init__.py:42:103: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/segment/__init__.py:40:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/segment/__init__.py:40:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/sendgrid/__init__.py:42:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/sendgrid/__init__.py:42:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/sftp/__init__.py:42:102: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/sftp/__init__.py:42:102: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/sftp/operators/sftp.py:228:109: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/sftp/operators/sftp.py:228:109: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/singularity/__init__.py:42:109: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/singularity/__init__.py:42:109: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/slack/__init__.py:42:103: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/slack/__init__.py:42:103: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/smtp/__init__.py:42:102: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/smtp/__init__.py:42:102: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/snowflake/__init__.py:42:107: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/snowflake/__init__.py:42:107: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/sqlite/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/sqlite/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/ssh/__init__.py:42:101: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/ssh/__init__.py:42:101: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/tableau/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/tableau/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/tabular/__init__.py:40:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/tabular/__init__.py:40:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/telegram/__init__.py:40:106: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/telegram/__init__.py:40:106: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/trino/__init__.py:42:103: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/trino/__init__.py:42:103: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/vertica/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/vertica/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/yandex/__init__.py:42:104: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/yandex/__init__.py:42:104: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers/zendesk/__init__.py:42:105: RUF100 Unused `noqa` directive (unused: `E501`) + airflow/providers/zendesk/__init__.py:42:105: RUF100 [*] Unused `noqa` directive (unused: `E501`) - airflow/providers_manager.py:1018:31: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/providers_manager.py:1018:31: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/serialization/serde.py:151:16: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/serialization/serde.py:151:16: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/serialization/serde.py:259:16: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/serialization/serde.py:259:16: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/serialization/serialized_objects.py:1027:9: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + airflow/serialization/serialized_objects.py:1027:9: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - airflow/serialization/serialized_objects.py:721:28: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/serialization/serialized_objects.py:721:28: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/serialization/serialized_objects.py:729:28: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + airflow/serialization/serialized_objects.py:729:28: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - airflow/serialization/serialized_objects.py:952:17: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + airflow/serialization/serialized_objects.py:952:17: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - airflow/settings.py:493:13: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + airflow/settings.py:493:13: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - docs/exts/docroles.py:54:23: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + docs/exts/docroles.py:54:23: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - tests/always/test_connection.py:187:164: RUF100 Unused `noqa` directive (unused: `E501`) + tests/always/test_connection.py:187:164: RUF100 [*] Unused `noqa` directive (unused: `E501`) - tests/api_connexion/endpoints/test_mapped_task_instance_endpoint.py:130:17: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + tests/api_connexion/endpoints/test_mapped_task_instance_endpoint.py:130:17: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - tests/api_connexion/schemas/test_task_instance_schema.py:112:9: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + tests/api_connexion/schemas/test_task_instance_schema.py:112:9: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - tests/api_connexion/test_auth.py:134:20: B009 Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. + tests/api_connexion/test_auth.py:134:20: B009 [*] Do not call `getattr` with a constant attribute value. It is not any safer than normal property access. - tests/api_connexion/test_auth.py:141:13: B010 Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. + tests/api_connexion/test_auth.py:141:13: B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access. - tests/api_connexion/t |
zanieb
approved these changes
Oct 9, 2023
charliermarsh
force-pushed
the
charlie/suggest
branch
from
5c21e6d to
70e2cfc
Compare
konstin
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Summary This PR upgrades some rules from "sometimes" to "always" fixes, now that we're getting ready to ship support in the CLI. The focus here was on identifying rules for which the diagnostic itself is high-confidence, and the fix itself is too (assuming that the diagnostic is correct). This is _unlike_ rules that _may_ be a false positive, like those that (e.g.) assume an object is a dictionary when you call `.values()` on it. Specifically, I upgraded: - A bunch of rules that only apply to `.pyi` files. - Rules that rewrite deprecated imports or aliases. - Some other misc. rules, like: `empty-print-string`, `unused-noqa`, `getattr-with-constant`. Open to feedback on any of these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades some rules from "sometimes" to "always" fixes, now that we're getting ready to ship support in the CLI. The focus here was on identifying rules for which the diagnostic itself is high-confidence, and the fix itself is too (assuming that the diagnostic is correct). This is unlike rules that may be a false positive, like those that (e.g.) assume an object is a dictionary when you call
.values()on it.Specifically, I upgraded:
.pyifiles.empty-print-string,unused-noqa,getattr-with-constant.Open to feedback on any of these.