Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Stylist quote detection with new f-string token #7328

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Update Stylist quote detection with new f-string token #7328

merged 1 commit into from
Sep 15, 2023

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Sep 13, 2023 •
edited
Loading

Summary

This PR updates Stylist quote detection to include the f-string tokens.

As f-strings cannot be used as docstrings, we'll skip the check for triple-quoted f-strings.

Test Plan

Add new test cases with f-strings.

fixes: #7293

This was referenced Sep 13, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dhruvmanila
Copy link
Member Author

dhruvmanila commented Sep 13, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhruvmanila dhruvmanila linked an issue Sep 13, 2023 that may be closed by this pull request
Update Stylist quote detection to use the new f-string tokens #7293
Closed
@dhruvmanila dhruvmanila added python312 Related to Python 3.12 core Related to core functionality labels Sep 13, 2023
This was referenced Sep 13, 2023
Merged
Merged
@dhruvmanila dhruvmanila mentioned this pull request Sep 14, 2023
Merged
@dhruvmanila dhruvmanila changed the base branch from dhruv/issue-7292 to dhruv/pep-701 September 14, 2023 02:49
@dhruvmanila dhruvmanila marked this pull request as ready for review September 14, 2023 03:40
@dhruvmanila dhruvmanila merged commit dd2178f into dhruv/pep-701 Sep 15, 2023
@dhruvmanila dhruvmanila deleted the dhruv/issue-7293 branch September 15, 2023 07:22
dhruvmanila added a commit that referenced this pull request Sep 18, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
0ebffeb 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
This was referenced Sep 18, 2023
Merged
Merged
Merged
dhruvmanila added a commit that referenced this pull request Sep 19, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
3a1e127 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
@dhruvmanila dhruvmanila mentioned this pull request Sep 19, 2023
Merged
dhruvmanila added a commit that referenced this pull request Sep 20, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
9f4f9d3 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
184ace9 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
b619f7b 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
This was referenced Sep 22, 2023
Merged
Merged
Merged
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
3690af2 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
@dhruvmanila dhruvmanila mentioned this pull request Sep 22, 2023
Merged
dhruvmanila added a commit that referenced this pull request Sep 26, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
f4f3134 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
@dhruvmanila dhruvmanila mentioned this pull request Sep 26, 2023
Merged
dhruvmanila added a commit that referenced this pull request Sep 27, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
9d2dd2c 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
dhruvmanila added a commit that referenced this pull request Sep 28, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
2c90d6a 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
@dhruvmanila dhruvmanila mentioned this pull request Sep 28, 2023
Merged
dhruvmanila added a commit that referenced this pull request Sep 29, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
deee2df 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
dhruvmanila added a commit that referenced this pull request Sep 29, 2023
@dhruvmanila
Update Stylist quote detection with new f-string token (#7328)
658435e 
## Summary

This PR updates `Stylist` quote detection to include the f-string
tokens.

As f-strings cannot be used as docstrings, we'll skip the check for
triple-quoted f-strings.

## Test Plan

Add new test cases with f-strings.

fixes: #7293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees
No one assigned
Labels
core Related to core functionality python312 Related to Python 3.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Stylist quote detection to use the new f-string tokens
2 participants
@dhruvmanila @MichaReiser