-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Arguments
to Parameters
in the AST
#6253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28d4dab
to
d26b3f2
Compare
d26b3f2
to
f8b496c
Compare
charliermarsh
commented
Aug 1, 2023
MichaReiser
approved these changes
Aug 1, 2023
e2bd8c5
to
e8bb002
Compare
5d063cc
to
0cbd6de
Compare
zanieb
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read most of this :)
0cbd6de
to
e76125e
Compare
e76125e
to
00268e4
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinux
Windows
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames a few AST nodes for clarity:
Arguments
is nowParameters
Arg
is nowParameter
ArgWithDefault
is nowParameterWithDefault
For now, the attribute names that reference
Parameters
directly are changed (e.g., onStmtFunctionDef
), but the attributes onParameters
itself are not (e.g.,vararg
). We may revisit that decision in the future.For context, the AST node formerly known as
Arguments
is used in function definitions. Formally (outside of the Python context), "arguments" typically refers to "the values passed to a function", while "parameters" typically refers to "the variables used in a function definition". E.g., if you Google "arguments vs parameters", you'll get some explanation like:We're thus deviating from Python's nomenclature in favor of a scheme that we find to be more precise.