[red-knot] Internal refactoring of visibility constraints API #15913
+160
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcreager
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
dcreager
changed the title
dcreager
added
internal
MichaReiser
reviewed
Feb 3, 2025
dcreager
commented
Feb 3, 2025
| pub(crate) struct VisibilityConstraint<'db>(VisibilityConstraintInner<'db>); | ||
|
|
||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub(crate) enum VisibilityConstraintInner<'db> { |
There was a problem hiding this comment.
Adding this as a separate type made it easier to verify that no callers are constructing this manually, and always use one of the builder's constructor methods
Comment on lines
+199
to
+201
| /// A newtype-index for a visibility constraint in a particular scope. | ||
| #[newtype_index] | ||
| pub(crate) struct ScopedVisibilityConstraintId; |
There was a problem hiding this comment.
Moved into this module to be near the other visibility constraint stuff
dcreager
force-pushed
the
dcreager/vc-api
branch
from
d1578ee to
b4eb067
Compare
carljm
approved these changes
Feb 3, 2025
dcreager
added a commit
that referenced
this pull request
Feb 4, 2025
* main: (66 commits) [red-knot] Use ternary decision diagrams (TDDs) for visibility constraints (#15861) [`pyupgrade`] Rename private type parameters in PEP 695 generics (`UP049`) (#15862) Simplify the `StringFlags` trait (#15944) [`flake8-pyi`] Make `PYI019` autofixable for `.py` files in preview mode as well as stubs (#15889) Docs (`linter.md`): clarify that Python files are always searched for in subdirectories (#15882) [`flake8-pyi`] Make PEP-695 functions with multiple type parameters fixable by PYI019 again (#15938) [red-knot] Use unambiguous invalid-syntax-construct for suppression comment test (#15933) Make `Binding::range()` point to the range of a type parameter's name, not the full type parameter (#15935) Update black deviations (#15928) [red-knot] MDTest: Fix line numbers in error messages (#15932) Preserve triple quotes and prefixes for strings (#15818) [red-knot] Hand-written MDTest parser (#15926) [`pylint`] Fix missing parens in unsafe fix for `unnecessary-dunder-call` (`PLC2801`) (#15762) nit: docs for ignore & select (#15883) [airflow] `BashOperator` has been moved to `airflow.providers.standard.operators.bash.BashOperator` (AIR302) (#15922) [`flake8-logging`] `.exception()` and `exc_info=` outside exception handlers (`LOG004`, `LOG014`) (#15799) [red-knot] Enforce specifying paths for mdtest code blocks in a separate preceding line (#15890) [red-knot] Internal refactoring of visibility constraints API (#15913) [red-knot] Implicit instance attributes (#15811) [`flake8-comprehensions`] Handle extraneous parentheses around list comprehension (`C403`) (#15877) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts some pure refactoring noise from #15861. This changes the API for creating and evaluating visibility constraints, but does not change how they are respresented internally. There should be no behavioral or performance changes in this PR.
Changes:
UseDefMapBuilder, makingSemanticIndexBuilderresponsible for constructing whatever visibility constraints it needs.