Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruff] Recode RUF025 to RUF037 (RUF037) #15258

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #15256.

Test Plan

cargo nextest run and cargo insta test.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+3 -3 violations, +0 -0 fixes in 3 projects; 52 projects unchanged)

RasaHQ/rasa (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- tests/core/training/test_interactive.py:663:58: RUF025 [*] Unnecessary empty iterable within a deque call
+ tests/core/training/test_interactive.py:663:58: RUF037 [*] Unnecessary empty iterable within a deque call

apache/airflow (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- tests/jobs/test_scheduler_job.py:5887:38: RUF025 [*] Unnecessary empty iterable within a deque call
+ tests/jobs/test_scheduler_job.py:5887:38: RUF037 [*] Unnecessary empty iterable within a deque call
- tests/jobs/test_scheduler_job.py:5888:43: RUF025 [*] Unnecessary empty iterable within a deque call
+ tests/jobs/test_scheduler_job.py:5888:43: RUF037 [*] Unnecessary empty iterable within a deque call

python-trio/trio (+0 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview


Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
RUF037 3 3 0 0 0
RUF025 3 0 3 0 0

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MichaReiser MichaReiser merged commit df6e5c0 into astral-sh:main Jan 5, 2025
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the RUF037 branch January 5, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recode Ruf025 to Ruf037
2 participants