[ruff] - add autofix for useless-if-else (RUF034)
#13852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AlexWaygood
reviewed
Oct 21, 2024
There was a problem hiding this comment.
I'm unsure if an autofix is a good idea for this rule, because it's hard for us to detect exactly what the mistake was. We can "fix" the code so that the violation no longer occurs, but we almost certainly can't figure out what the user actually wanted to write.
The decision not to implement an autofix for this rule in its initial implementation was a deliberate choice: see #13218 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds (sometimes-applicable) autofix for
useless-if-elsehttps://docs.astral.sh/ruff/rules/RUF034Test Plan
cargo test