Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] clarify mdtest README #13720

Merged
merged 4 commits into from
Oct 11, 2024
Merged

[red-knot] clarify mdtest README #13720

merged 4 commits into from
Oct 11, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Oct 11, 2024

Address a potential point of confusion that bit a contributor in #13719

Also remove a no-longer-accurate line about bare error: assertions (which are no longer allowed) and clarify another point about which kinds of error assertions to use.

@carljm carljm added the red-knot Multi-file analysis & type inference label Oct 11, 2024
@carljm carljm force-pushed the cjm/mdtest-readme branch from 85e8fa3 to 699f412 Compare October 11, 2024 18:57
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. #13720 (comment) would be nice but isn't crucial!

@carljm carljm merged commit 3209953 into main Oct 11, 2024
19 checks passed
@carljm carljm deleted the cjm/mdtest-readme branch October 11, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants