Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allow-unused-imports setting from the common lint options #13677

Merged

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Oct 8, 2024

Summary

Fixes #13668

Luckily, the lint.allow_unused_imports setting isn't read anywhere.
However, this could still be considered a breaking change because Ruff might fail to read a previously valid configuration.
I do think that it should be very unlikely, considering that the configuration was "useless" before.

The setting remains available under lint.pyflakes

#[option(
default = r#"[]"#,
value_type = "list[str]",
example = r#"allowed-unused-imports = ["hvplot.pandas"]"#
)]
pub allowed_unused_imports: Option<Vec<String>>,

Test Plan

cargo test

@MichaReiser MichaReiser added the configuration Related to settings and configuration label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added this to the v0.7 milestone Oct 8, 2024
@AlexWaygood AlexWaygood changed the base branch from main to ruff-0.7 October 8, 2024 13:47
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as part of a minor release (which it will be!)

@MichaReiser MichaReiser merged commit 0db39af into ruff-0.7 Oct 8, 2024
20 checks passed
@MichaReiser MichaReiser deleted the micha/remove-allow-unused-imports-from-lint-options branch October 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Related to settings and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowed-unused-imports has incorrect documentation
3 participants