Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of ruff_benchmark on NixOS #13366

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

MichaReiser
Copy link
Member

Summary

See #13299 (comment)

This PR fixes the ruff_benchmark build on NixOS by not relying on the unprefixed_malloc_on_supported_platforms feature and instead export the conf as _rjem_malloc_conf

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Sep 16, 2024
Copy link

codspeed-hq bot commented Sep 16, 2024

CodSpeed Performance Report

Merging #13366 will improve performances by 4.1%

Comparing micha/fix-jemalloc-conf-nix (ae9987e) with main (1365b08)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark main micha/fix-jemalloc-conf-nix Change
linter/default-rules[pydantic/types.py] 1.9 ms 1.8 ms +4.1%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser
Copy link
Member Author

Hmm okay, now the conf variable isn't picked up anymore. Perfect

@MichaReiser
Copy link
Member Author

Let's see if this works. I don't see any new decay calls. The perf differences are only re_alloc.

@MichaReiser MichaReiser merged commit 3b57faf into main Sep 16, 2024
20 checks passed
@MichaReiser MichaReiser deleted the micha/fix-jemalloc-conf-nix branch September 16, 2024 07:41
@GaetanLepage
Copy link
Contributor

Backporting this patch to 0.6.5 is working :)

@MichaReiser
Copy link
Member Author

MichaReiser commented Sep 16, 2024

Backporting this patch to 0.6.5 is working :)

Nice. Thanks for confirming. Let's hope our benchmarks don't regress to being flaky again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants