Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofix PIE810 rule violations #3360

Closed
Skylion007 opened this issue Mar 6, 2023 · 2 comments · Fixed by #3411
Closed

Autofix PIE810 rule violations #3360

Skylion007 opened this issue Mar 6, 2023 · 2 comments · Fixed by #3411
Assignees
@kyoto7250
Labels
fixes Related to suggested fixes for violations good first issue Good for newcomers

Comments

@Skylion007
Copy link
Contributor

PIE810 currently does not have implement any autofixes, but the rule should be readily autofixable using similar logic to SIM101 (which effectively does the same thing with isinstance calls). It would be nice if someone could implement this autofix. This rule is a common minor performance pitfall so having autofixes would help turning this rule on for large codebases.
@charliermarsh charliermarsh added fixes Related to suggested fixes for violations good first issue Good for newcomers labels Mar 6, 2023
@kyoto7250
Copy link
Contributor

@charliermarsh

Hello, I am interested in working on this issue. Could you please assign it to me?

@charliermarsh
Copy link
Member

Cool, thanks :)

kyoto7250 added a commit to kyoto7250/ruff that referenced this issue Mar 9, 2023
@kyoto7250
Autofix PIE810 rule violations
a71a446 
astral-sh#3360
kyoto7250 added a commit to kyoto7250/ruff that referenced this issue Mar 9, 2023
@kyoto7250
Autofix PIE810 rule violations
b19fbe8 
astral-sh#3360
kyoto7250 added a commit to kyoto7250/ruff that referenced this issue Mar 9, 2023
@kyoto7250
Autofix PIE810 rule violations
6a936b7 
astral-sh#3360
@kyoto7250 kyoto7250 mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyoto7250 kyoto7250

Labels
fixes Related to suggested fixes for violations good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Autofix PIE810 rule violations kyoto7250/ruff
3 participants
@charliermarsh @Skylion007 @kyoto7250