Use call

astral-sh · Nov 21, 2024 · fda25ed · fda25ed
1 parent 1ddef63
commit fda25ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/crates/ruff_linter/resources/test/fixtures/flake8_pytest_style/PT006.py b/crates/ruff_linter/resources/test/fixtures/flake8_pytest_style/PT006.py
@@ -71,7 +71,7 @@ def test_csv_with_parens(param1, param2):
     ...
 
 
-parametrize = pytest.mark.parametrize(("param1,param2"), [(1, 2), (3, 4)])
+parametrize = pytest.mark.parametrize(argnames=("param1,param2"), argvalues=[(1, 2), (3, 4)])
 
 @parametrize
 def test_csv_with_parens_decorator(param1, param2):

diff --git a/crates/ruff_linter/src/rules/flake8_pytest_style/rules/parametrize.rs b/crates/ruff_linter/src/rules/flake8_pytest_style/rules/parametrize.rs
@@ -800,21 +800,20 @@ pub(crate) fn parametrize(checker: &mut Checker, call: &ExprCall) {
         return;
     }
 
-    let ExprCall { arguments, .. } = call;
     if checker.enabled(Rule::PytestParametrizeNamesWrongType) {
-        if let Some(names) = arguments.find_argument("argnames", 0) {
+        if let Some(names) = call.arguments.find_argument("argnames", 0) {
             check_names(checker, call, names);
         }
     }
     if checker.enabled(Rule::PytestParametrizeValuesWrongType) {
-        if let Some(names) = arguments.find_argument("argnames", 0) {
-            if let Some(values) = arguments.find_argument("argvalues", 1) {
+        if let Some(names) = call.arguments.find_argument("argnames", 0) {
+            if let Some(values) = call.arguments.find_argument("argvalues", 1) {
                 check_values(checker, names, values);
             }
         }
     }
     if checker.enabled(Rule::PytestDuplicateParametrizeTestCases) {
-        if let Some(values) = arguments.find_argument("argvalues", 1) {
+        if let Some(values) = call.arguments.find_argument("argvalues", 1) {
             check_duplicates(checker, values);
         }
     }