Remove no longer needed preview: true options from tests

astral-sh · Jan 3, 2025 · 62633a3 · 62633a3
1 parent 5cd85f1
commit 62633a3
Show file tree

Hide file tree

Showing 10 changed files with 33 additions and 80 deletions.
diff --git a/...er/resources/test/fixtures/ruff/expression/join_implicit_concatenated_string.options.json b/...er/resources/test/fixtures/ruff/expression/join_implicit_concatenated_string.options.json
diff --git a/...s/test/fixtures/ruff/expression/join_implicit_concatenated_string_assignment.options.json b/...s/test/fixtures/ruff/expression/join_implicit_concatenated_string_assignment.options.json
diff --git a/...ces/test/fixtures/ruff/expression/join_implicit_concatenated_string_preserve.options.json b/...ces/test/fixtures/ruff/expression/join_implicit_concatenated_string_preserve.options.json
@@ -1,11 +1,9 @@
 [
   {
-    "quote_style": "preserve",
-    "preview": "enabled"
+    "quote_style": "preserve"
   },
   {
     "quote_style": "preserve",
-    "preview": "enabled",
     "target_version": "py312"
   }
 ]
diff --git a/crates/ruff_python_formatter/resources/test/fixtures/ruff/range_formatting/stub.options.json b/crates/ruff_python_formatter/resources/test/fixtures/ruff/range_formatting/stub.options.json
@@ -1,6 +1,5 @@
 [
   {
-    "preview": "enabled",
     "source_type": "Stub"
   }
 ]
diff --git a/...ormatter/resources/test/fixtures/ruff/statement/assignment_split_value_first.options.json b/...ormatter/resources/test/fixtures/ruff/statement/assignment_split_value_first.options.json
diff --git a/...on_formatter/tests/snapshots/format@expression__join_implicit_concatenated_string.py.snap b/...on_formatter/tests/snapshots/format@expression__join_implicit_concatenated_string.py.snap
@@ -355,22 +355,7 @@ f"aaaaaaaaaaaaaaaa \
 )
 ```
 
-## Outputs
-### Output 1
-```
-indent-style               = space
-line-width                 = 88
-indent-width               = 4
-quote-style                = Double
-line-ending                = LineFeed
-magic-trailing-comma       = Respect
-docstring-code             = Disabled
-docstring-code-line-width  = "dynamic"
-preview                    = Enabled
-target_version             = Py39
-source_type                = Python
-```
-
+## Output
 ```python
 "aaaaaaaaabbbbbbbbbbbbbbbbbbbb"  # Join
 
@@ -616,12 +601,9 @@ assert (
 ##############################################################################
 # Use can_omit_optional_parentheses layout to avoid an instability where the formatter
 # picks the can_omit_optional_parentheses layout when the strings are joined.
-if f"implicitconcatenatedstring" + f"implicitconcadddddddddddedring" * len([
-    aaaaaa,
-    bbbbbbbbbbbbbbbb,
-    cccccccccccccccccc,
-    ddddddddddddddddddddddddddd,
-]):
+if f"implicitconcatenatedstring" + f"implicitconcadddddddddddedring" * len(
+    [aaaaaa, bbbbbbbbbbbbbbbb, cccccccccccccccccc, ddddddddddddddddddddddddddd]
+):
     pass
 
 # Keep parenthesizing multiline - implicit concatenated strings
@@ -792,3 +774,26 @@ f"aaaaaaaaaaaaaaaa \
             ddddddddddddddddddd"  # comment 4
 )
 ```
+
+
+## Preview changes
+```diff
+--- Stable
++++ Preview
+@@ -242,9 +242,12 @@
+ ##############################################################################
+ # Use can_omit_optional_parentheses layout to avoid an instability where the formatter
+ # picks the can_omit_optional_parentheses layout when the strings are joined.
+-if f"implicitconcatenatedstring" + f"implicitconcadddddddddddedring" * len(
+-    [aaaaaa, bbbbbbbbbbbbbbbb, cccccccccccccccccc, ddddddddddddddddddddddddddd]
+-):
++if f"implicitconcatenatedstring" + f"implicitconcadddddddddddedring" * len([
++    aaaaaa,
++    bbbbbbbbbbbbbbbb,
++    cccccccccccccccccc,
++    ddddddddddddddddddddddddddd,
++]):
+     pass
+ 
+ # Keep parenthesizing multiline - implicit concatenated strings
+```
diff --git a/...r/tests/snapshots/format@expression__join_implicit_concatenated_string_assignment.py.snap b/...r/tests/snapshots/format@expression__join_implicit_concatenated_string_assignment.py.snap
@@ -1,7 +1,6 @@
 ---
 source: crates/ruff_python_formatter/tests/fixtures.rs
 input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/expression/join_implicit_concatenated_string_assignment.py
-snapshot_kind: text
 ---
 ## Input
 ```python
@@ -300,22 +299,7 @@ aaaaa[aaaaaaaaaaa] = (
 )
 ```
 
-## Outputs
-### Output 1
-```
-indent-style               = space
-line-width                 = 88
-indent-width               = 4
-quote-style                = Double
-line-ending                = LineFeed
-magic-trailing-comma       = Respect
-docstring-code             = Disabled
-docstring-code-line-width  = "dynamic"
-preview                    = Enabled
-target_version             = Py39
-source_type                = Python
-```
-
+## Output
 ```python
 ## Implicit concatenated strings with a trailing comment but a non splittable target.
 

diff --git a/...ter/tests/snapshots/format@expression__join_implicit_concatenated_string_preserve.py.snap b/...ter/tests/snapshots/format@expression__join_implicit_concatenated_string_preserve.py.snap
@@ -1,7 +1,6 @@
 ---
 source: crates/ruff_python_formatter/tests/fixtures.rs
 input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/expression/join_implicit_concatenated_string_preserve.py
-snapshot_kind: text
 ---
 ## Input
 ```python
@@ -31,7 +30,7 @@ line-ending                = LineFeed
 magic-trailing-comma       = Respect
 docstring-code             = Disabled
 docstring-code-line-width  = "dynamic"
-preview                    = Enabled
+preview                    = Disabled
 target_version             = Py39
 source_type                = Python
 ```
@@ -63,7 +62,7 @@ line-ending                = LineFeed
 magic-trailing-comma       = Respect
 docstring-code             = Disabled
 docstring-code-line-width  = "dynamic"
-preview                    = Enabled
+preview                    = Disabled
 target_version             = Py312
 source_type                = Python
 ```

diff --git a/crates/ruff_python_formatter/tests/snapshots/format@range_formatting__stub.pyi.snap b/crates/ruff_python_formatter/tests/snapshots/format@range_formatting__stub.pyi.snap
@@ -1,7 +1,6 @@
 ---
 source: crates/ruff_python_formatter/tests/fixtures.rs
 input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/range_formatting/stub.pyi
-snapshot_kind: text
 ---
 ## Input
 ```python
@@ -34,7 +33,7 @@ line-ending                = LineFeed
 magic-trailing-comma       = Respect
 docstring-code             = Disabled
 docstring-code-line-width  = "dynamic"
-preview                    = Enabled
+preview                    = Disabled
 target_version             = Py39
 source_type                = Stub
 ```

diff --git a/...f_python_formatter/tests/snapshots/format@statement__assignment_split_value_first.py.snap b/...f_python_formatter/tests/snapshots/format@statement__assignment_split_value_first.py.snap
@@ -1,7 +1,6 @@
 ---
 source: crates/ruff_python_formatter/tests/fixtures.rs
 input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/statement/assignment_split_value_first.py
-snapshot_kind: text
 ---
 ## Input
 ```python
@@ -242,22 +241,7 @@ type A[VeryLongTypeNameThatShouldBreakFirstToTheRightBeforeSplitngtinthatExceeds
 
 ```
 
-## Outputs
-### Output 1
-```
-indent-style               = space
-line-width                 = 88
-indent-width               = 4
-quote-style                = Double
-line-ending                = LineFeed
-magic-trailing-comma       = Respect
-docstring-code             = Disabled
-docstring-code-line-width  = "dynamic"
-preview                    = Enabled
-target_version             = Py39
-source_type                = Python
-```
-
+## Output
 ```python
 #######
 # Unsplittable target and value