[FIX] PYI011: recognize Bool / Float / Complex numbers as simpl…

…e defaults
astral-sh · Mar 12, 2023 · 42307fd · 42307fd
1 parent 7fb7268
commit 42307fd
Showing 1 changed file with 28 additions and 4 deletions.
diff --git a/crates/ruff/src/rules/flake8_pyi/rules/simple_defaults.rs b/crates/ruff/src/rules/flake8_pyi/rules/simple_defaults.rs
@@ -61,8 +61,22 @@ fn is_valid_default_value_with_annotation(default: &Expr, checker: &Checker) ->
             value: Constant::Bytes(..),
             ..
         } => return checker.locator.slice(default).len() <= 50,
+        // 123
+        // True / False
+        // 3.14
         ExprKind::Constant {
-            value: Constant::Int(..),
+            value:
+                Constant::Int(..)
+                | Constant::Bool(..)
+                | Constant::Float(..)
+            ..
+        } => {
+            return checker.locator.slice(default).len() <= 10;
+        }
+        // 2j
+        ExprKind::Constant {
+            value:
+                Constant::Complex(..)
             ..
         } => {
             return checker.locator.slice(default).len() <= 10;
@@ -71,8 +85,18 @@ fn is_valid_default_value_with_annotation(default: &Expr, checker: &Checker) ->
             op: Unaryop::USub,
             operand,
         } => {
+            // - 1
+            // - 3.14
+            if let ExprKind::Constant {
+                value: Constant::Int(..) | Constant::Float(..),
+                ..
+            } = &operand.node
+            {
+                return checker.locator.slice(operand).len() <= 10;
+            }
+            // - 2j
             if let ExprKind::Constant {
-                value: Constant::Int(..),
+                value: Constant::Complex(..),
                 ..
             } = &operand.node
             {
@@ -96,7 +120,7 @@ fn is_valid_default_value_with_annotation(default: &Expr, checker: &Checker) ->
                 // 1 + 2j
                 // 1 - 2j
                 if let ExprKind::Constant {
-                    value: Constant::Int(..),
+                    value: Constant::Int(..) | Constant::Float(..),
                     ..
                 } = &left.node
                 {
@@ -109,7 +133,7 @@ fn is_valid_default_value_with_annotation(default: &Expr, checker: &Checker) ->
                     // -1 + 2j
                     // -1 - 2j
                     if let ExprKind::Constant {
-                        value: Constant::Int(..),
+                        value: Constant::Int(..) | Constant::Float(..),
                         ..
                     } = &operand.node
                     {