Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed context.childs. #140

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Removed context.childs. #140

merged 1 commit into from
Apr 26, 2016

Conversation

Kanaye
Copy link
Collaborator

@Kanaye Kanaye commented Apr 24, 2016

I think I tested enough.
I will think about the tests mentioned in #111 and open an P.R. once I have a clean implementation.
Resolves #111.

Context will now be build with the parent context, the model and the
._index array of the collection in each-queries.
Resolves astoilkov#111.
@astoilkov
Copy link
Owner

I think you have missed one place where the ._childs property is used:

var childContexts = domQuery._context.childs;

@Kanaye
Copy link
Collaborator Author

Kanaye commented Apr 25, 2016

Whoops. You're totally right. I think I removed it in my local repository and forgot to push it. I'll push it once I'm back at my workstation

@astoilkov
Copy link
Owner

astoilkov commented Apr 25, 2016

Perfect

@Kanaye
Copy link
Collaborator Author

Kanaye commented Apr 25, 2016

Okay, maybe I should get a cup of coffee before I answer stuff on github in the morning 😄 .

My workstation branch and the one here on gihub have no difference.

I also was curious how the tests passed cause I was sure they were failling when I worked on it.

The line you linked above is in the dist/query directory and because I'm not committing the built files (because I think the repositories dist folder should stay on the current release) so these are 'outdated'. Here the line in the source diff where I removed it: https://github.com/astoilkov/jsblocks/pull/140/files#diff-1750a8a6163be12789b27db2dc590968L520

@astoilkov
Copy link
Owner

Oops. Sorry. We both got confused here. :D Merging

@astoilkov astoilkov merged commit a6acd83 into astoilkov:master Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants