Now cloning __props__ and changed order in 'with' #130
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning the __props__ property of contexts to prevent it from being overwritten e.g. with new Views and changed the order of execution in the 'with'-data-querie to first push the context and then modify it.
|
This is a great catch. |
astoilkov
added a commit
that referenced
this pull request
Jan 20, 2016
Now cloning __props__ and changed order in 'with'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning the props property of contexts to prevent it from being
overwritten e.g. with new Views and changed the order of execution in the
'with'-data-querie to first push the context and then modify it.
This solves the problem that e.g. the
view-data-query overrides the$view-property of all views (including none views like the application context).Here an example visualising the problem
I have tested it and thought about if it could have negative side effects.
I didn't found anything.
Closes #129.