Updating/Insetring of wrong nodes fixed. Closes #104 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2015 00:06
Added an rendering type Expression.NodeWise that will return an array with the values positioned in the order of the node when passed to Expression.GetValue. Expressios objects now have a property nodeLength and chunks of expressions now have an array nodePositions containing the the position of the nodes the expression updates. Updated VirtualElement.syncChildren to delete all nodes related to an expression and to update all nodes of an expression with a changed value.
Added tests for updateing and inserting/deleting the right nodes "VirtualElement.syncChildren()"
|
I will take a look at the solution for this soon and will merge it. |
|
I removed the Also just take your time to review the changes. The PR-might change over time (as it did now) but it won't run away 😄. |
Kanaye
force-pushed
the
VE-sync-ffixes
branch
from
f607e62 to
1d48456
Compare
Also edited test so that it catches bugs like that.
|
Wow. Cool. We have a lot of more because we are launching Caret. I will take a look in the next couple of days. This way you will also have time to make changes if you want. :) |
|
I am ready to merge the pull request. Do you have any additional changes you want to add before that? |
|
Great! No I have no additional changes. |
astoilkov
added a commit
that referenced
this pull request
Oct 28, 2015
Updating/Insetring of wrong nodes fixed. Closes #104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details read the message of the first commit 😉.
If you find an edge case I didn't fix or you don't like something about this solution feel free to say.
Closes #104