escape-unescape '<' character for WebVTT #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this change, tests fail since unescaping the |
|
Yes, you are right. I've corrected it just now. |
|
Thanks for the PR! ❤️ |
|
Thank for the merging! Could you please create a tag for it? So that I can integrate the new change with my project. |
|
I've created a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
We have already escape "&" because of my reporting in this ticket #85, but we are lacking of escape-unescape for "<", with escape-unescape "<" character, we can fulfill the requirement of WebVTT format in escaping characters.