Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing nlopt functions for weighted tolerance (nlopt_set_x_weight and cie) #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jchiquet
Copy link
Contributor

@jchiquet jchiquet commented Nov 23, 2022

The three following functions detailed in the documention pages of NLopt

nlopt_result nlopt_set_x_weights(nlopt_opt opt, const double *w);
nlopt_result nlopt_set_x_weights1(nlopt_opt opt, const double w);
nlopt_result nlopt_get_x_weights(const nlopt_opt opt, double *w);

are not exposed in nloptrAPI.h. I suggest in this PR some simple modifications which hopefully give access to these functionalities.

@astamm
Copy link
Owner

astamm commented Dec 22, 2022

Hi @jchiquet. I assume you already tried to use them as currently exposed in your PR and it all works smoothly?

@jchiquet
Copy link
Contributor Author

jchiquet commented Jan 2, 2023

Hi @jchiquet. I assume you already tried to use them as currently exposed in your PR and it all works smoothly?

Indeed. Do you need an example?

@astamm
Copy link
Owner

astamm commented Jan 2, 2023

If you can provide an example, that would be ideal. I will integrate it in the unit tests so we can make sure it works on all platforms. Thanks! And happy new year!

@astamm
Copy link
Owner

astamm commented Feb 9, 2023

Hi @jchiquet. The master branch is undergoing a series of patch changes. Could you update this branch to make sure it still works. And can you please add the example we discussed so that I can then merge your PR? Thanks a lot.

@jchiquet
Copy link
Contributor Author

jchiquet commented Feb 9, 2023

I will, but don't have time right now. Plus, this doesn't seem to be a very urgent/important fix on my side.

@astamm
Copy link
Owner

astamm commented Oct 4, 2023

Hey @jchiquet. If you find 5 minutes to add an example, I could merge this PR and include it in the next release. I am planning a release soon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants