This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Refactored to use ES6 modules and bundle with rollup #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I had to increase the test timeout because the some tests timed out on my PC |
|
@vibornoff any feedback on this? do you have intentions of merging this? |
|
@dignifiedquire , sorry, I'm out of spare time. |
|
@vibornoff Thanks for the quick reply. No need to be sorry. I am going to do some experiments with this branch and see if I can get things into a good state on my fork for now. |
|
Bump |
|
@vibornoff can we help? What do you need to be able to merge this? |
|
@alippai , open gitter.im please |
Renamed BigNumber_constructor for consistency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in issue #119
I tried to disturb the least amount of code and kept the general structure, but some restructuring was needed to keep the interface and to avoid assigning to imported values.
Locally all tests passed.