Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added source page buttons for Fink and Data Central DAS #697

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

ddobie
Copy link
Contributor

@ddobie ddobie commented Sep 4, 2023

Fix #695.

Partially addresses #698.

@ddobie ddobie requested a review from ajstewart September 4, 2023 23:42
@ddobie ddobie marked this pull request as ready for review September 4, 2023 23:46
@ajstewart
Copy link
Contributor

Should be fine but have you loaded up the website to check? Just in case it causes an overspill or something, perhaps post a screenshot if you can.

@ddobie
Copy link
Contributor Author

ddobie commented Sep 5, 2023

Yeah I think it's fine

image

Even if you open it in a narrow window it looks as okay as it possibly could

image

Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Have to think of some more to add and fill the whole bar!

@ddobie ddobie merged commit e46b79e into dev Sep 6, 2023
@ddobie ddobie deleted the add-das-and-fink branch September 6, 2023 05:42
@ddobie
Copy link
Contributor Author

ddobie commented Oct 3, 2023

@anaismoller see above for what it looks like

@anaismoller
Copy link

looks great! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add access to Data Central Data Aggregation Service
3 participants