Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed home counts and new source count #676

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Conversation

ajstewart
Copy link
Contributor

@ajstewart ajstewart commented Jan 25, 2023

  • The expensive counts have been removed from the homepage.
  • Removed the sky coverage map from the homepage.
  • The new sources count has been removed from the run detail page.
  • n_new_sources column added to run model.
  • migration file will calculate n_new_sources to populate new column.
  • Updated scheme diagrams.
  • Fixed link to jupyterhub.

Note: Currently the time field of the pipeline run is set to auto_now which means that the time that is reflected on the pipeline run is updated whenever the model object itself is updated. This means that running the migration in this PR will update the 'time run' of each job to the time of the migration.

Fixes #605.

- The expensive counts have been removed from the homepage.
- The new sources count has been removed from the run detail page.
- `n_new_sources` column added to run model.
- migration file will calculate n_new_sources to populate new column.
- Updated scheme diagrams.
- Fixed link to jupyterhub.
@ajstewart ajstewart added the enhancement New feature or request label Jan 25, 2023
@ajstewart ajstewart self-assigned this Jan 25, 2023
@ajstewart ajstewart marked this pull request as ready for review January 25, 2023 20:20
@ajstewart ajstewart requested a review from ddobie January 25, 2023 20:20
@ajstewart
Copy link
Contributor Author

@ddobie for whenever is convenient this PR removes the expensive count queries on the home page and also the count of the new sources on the run detail page.

The migration has been setup to fill in a new n_new_sources column in the run model with one off counts so that migration will take a little bit to run.

Also note that currently all tests are failing on GitHub as our test instance doesn't respect the poetry lock file and instead installs the latest versions with respect to the conditions set out in the pyproject file. This means that an update of something is not currently compatible with the pipeline as it is. All my tests pass locally however with an environment installed from the lock file.

@ddobie
Copy link
Contributor

ddobie commented Jan 25, 2023

I will trust that it works :p

@ddobie ddobie merged commit 94bfccf into dev Jan 25, 2023
@ddobie ddobie deleted the iss605-remove-home-counts branch January 25, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count queries are expensive
2 participants