Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed NED links #623

Merged
merged 2 commits into from
Feb 14, 2022
Merged

fixed NED links #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98ef540
fixed NED links
marxide Feb 14, 2022
f539db3
updated changelog
marxide Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

#### Fixed

- Fixed broken NED links for coordinates with many decimal places [#623](https://github.com/askap-vast/vast-pipeline/pull/623).
- Added an error handler for the external source queries (e.g. SIMBAD) [#616](https://github.com/askap-vast/vast-pipeline/pull/616).
- Stopped JS9 from changing the page titles [#597](https://github.com/askap-vast/vast-pipeline/pull/597).
- Fixed regression issues with pandas 1.4 [#586](https://github.com/askap-vast/vast-pipeline/pull/586).
Expand All @@ -70,6 +71,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

#### List of PRs

- [#623](https://github.com/askap-vast/vast-pipeline/pull/623): fix: fixed NED links.
- [#616](https://github.com/askap-vast/vast-pipeline/pull/616): fix: added error handling to external queries.
- [#614](https://github.com/askap-vast/vast-pipeline/pull/614): feat: Refactored add to favourites button to avoid refresh.
- [#597](https://github.com/askap-vast/vast-pipeline/pull/597): fix: Update detail page titles.
Expand Down
4 changes: 2 additions & 2 deletions templates/source_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@
<h1 class="h3 mb-2 text-gray-800"><strong>Source:</strong> {{ source.name }}</h1>
<div class="">
{% include 'source_fav_button.html' %}
<a href="http://simbad.u-strasbg.fr/simbad/sim-coo?CooEpoch=2000&Coord={{ source.aladin_ra }}d{{ source.aladin_dec }}d&Radius.unit=arcmin&CooEqui=2000&CooFrame=FK5&Radius=2'"
<a href="http://simbad.u-strasbg.fr/simbad/sim-coo?CooEpoch=2000&Coord={{ source.aladin_ra|floatformat:6 }}d{{ source.aladin_dec|floatformat:6 }}d&Radius.unit=arcmin&CooEqui=2000&CooFrame=FK5&Radius=2'"
class="d-none d-sm-inline-block btn btn-sm btn-info btn-icon-split shadow-sm" target="_blank"
title="SIMBAD cone search with 2 arcmin radius.">
<span class="icon text-white-600">
<i class="fas fa-info-circle fa-sm"></i>
</span>
<span class="text">SIMBAD</span>
</a>
<a href="https://ned.ipac.caltech.edu/conesearch?search_type=Near%20Position%20Search&coordinates={{ source.aladin_ra }}d%20{{ source.aladin_dec }}d&radius=2.0&in_csys=Equatorial&in_equinox=J2000.0&out_csys=Equatorial&out_equinox=J2000.0&hconst=67.8&omegam=0.308&omegav=0.692&wmap=4&corr_z=1"
<a href="https://ned.ipac.caltech.edu/conesearch?search_type=Near%20Position%20Search&coordinates={{ source.aladin_ra|floatformat:6 }}d%20{{ source.aladin_dec|floatformat:6 }}d&radius=2.0&in_csys=Equatorial&in_equinox=J2000&out_csys=Same%20as%20Input&out_equinox=Same%20as%20Input&obj_sort=Distance%20to%20search%20center&hconst=67.8&omegam=0.308&omegav=0.692&wmap=4&corr_z=1&z_constraint=Unconstrained&z_unit=z&ot_include=ANY"
class="d-none d-sm-inline-block btn btn-sm btn-info btn-icon-split shadow-sm" target="_blank"
title="NED cone search with 2 arcmin radius.">
<span class="icon text-white-600">
Expand Down