Fixed restore run forced measurements associations #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Forced IDs were not being considered when working out what associations to delete.
- Ensured in the test that associations are equal in length. - Turned on forced measurements for restore test. - Fixed the setting of the run n_meas value at the end of the restore run process.
- [skip ci]
marxide
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luckily it is a simple fix - forced IDs were not being considered when working out what associations to delete. They are now included.
I've also turned on forced extraction in the restore test and also added the test that the number of associations should be the same between the original and restored run.
Fixes #599.