Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detail page titles #597

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Update detail page titles #597

merged 3 commits into from
Feb 4, 2022

Conversation

marxide
Copy link
Contributor

@marxide marxide commented Jan 10, 2022

Adds the object IDs to the detail page titles (the text set by <title> tags). e.g. the title for a source detail page is now "VAST Pipeline: Source ID x" where x is the source ID number. The measurement, run, and image detail page titles have also been updated.

Also includes a new JS9 config setting to prevent JS9 displays from modifying the page titles.

@marxide marxide added the UI User Interface label Jan 10, 2022
Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had never noticed it doing that until I saw this!

I think this would be good to go with a changelog update?

@marxide marxide added the bug Something isn't working label Feb 2, 2022
@marxide marxide force-pushed the detail-page-titles branch from 78b655b to 26e7e42 Compare February 3, 2022 17:12
@marxide marxide force-pushed the detail-page-titles branch from 26e7e42 to 4cee518 Compare February 4, 2022 17:54
@marxide marxide force-pushed the detail-page-titles branch from 4cee518 to 0070875 Compare February 4, 2022 17:55
@marxide marxide linked an issue Feb 4, 2022 that may be closed by this pull request
@marxide marxide merged commit b9d741e into dev Feb 4, 2022
@marxide marxide deleted the detail-page-titles branch February 4, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source detail page title is changed by JS9
2 participants