Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added processing spinner to source query table #551

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Conversation

marxide
Copy link
Contributor

@marxide marxide commented Jun 10, 2021

A spinner will appear in the table when a query is processing.
Closes #531 [skip ci]

@marxide marxide self-assigned this Jun 10, 2021
@marxide marxide marked this pull request as ready for review June 10, 2021 18:38
@marxide marxide added enhancement New feature or request javascript Pull requests that update Javascript code UI User Interface labels Jun 10, 2021
@marxide marxide requested a review from ajstewart June 11, 2021 16:31
@ajstewart
Copy link
Contributor

I tried to test this but I couldn't do a search that took long enough to see it. Do you have an example of what it looks like?

@marxide
Copy link
Contributor Author

marxide commented Jun 23, 2021

Sorry for the delay, just got back from vacation.

I had the same problem, so I put a time.sleep into the source query to force it to be slow. It overlays an animated spinner in the middle of the table until the results are returned.

Source query results spinner

@marxide marxide merged commit 8607060 into dev Jun 24, 2021
@marxide marxide deleted the issue-531-query-spinner branch June 24, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query search button should give some indication that searching is happening
2 participants