Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added lightgallery support, layout update, minor fixes and additions #494

Merged
merged 10 commits into from
Apr 29, 2021

Conversation

ajstewart
Copy link
Contributor

@ajstewart ajstewart commented Apr 27, 2021

A further documentation PR that includes:

  • Added light gallery support for images using https://github.com/g-provost/lightgallery-markdown.
  • Fixed docstring in config.py.
  • Updated all image captions.
  • Split off DataTables and Tags and Favourites to their own pages.
  • Expanded documentation of the documentation.
  • Enclosed all file examples in example admonition.
  • Renamed docs/quickstart -> docs/gettingstarted.
  • Added acknowledgements page.
  • Moved FAQs to before Reference.
  • Fixed MathJax and instant navigation.
  • Removed random link from contributing overview page.
  • Removed softlink docs/readme.md as the repo readme is no longer used directly in the docs.
  • Minor typo fixes.

Lightgallery example when opening images:
Screen Shot 2021-04-27 at 17 00 54

@ajstewart ajstewart changed the title Added lightgallery support Docs: Added lightgallery support, layout update, minor fixes and additions Apr 27, 2021
* Fixed docstring in config.py.
* Updated all image captions.
* Split off `DataTables` and `Tags and Favourites` to their own pages.
* Expanded documentation of the documentation.
* Enclosed all file examples in example admonition.
* Renamed docs/quickstart -> docs/gettingstarted.
* Added acknowledgements page.
* Moved FAQs to before Reference.
* Fixed MathJax and instant navigation.
@ajstewart ajstewart added this to the v0.3.0 milestone Apr 27, 2021
@ajstewart ajstewart added the documentation Improvements or additions to documentation label Apr 27, 2021
@ajstewart
Copy link
Contributor Author

@marxide as I went through every page hunting for images I also took the time to do some tidying and fixing, which I've summarised in the head comment.

I think the contributing section is still a bit raw as I don't think either of us have really touched it, but I made sure to expand the documentation bit, seeing as there are now quite a few custom bolt ons. It probably needs further work beyond #492.

@ajstewart ajstewart marked this pull request as ready for review April 27, 2021 23:01
@ajstewart ajstewart requested a review from marxide April 27, 2021 23:01
@ajstewart ajstewart self-assigned this Apr 27, 2021
ajstewart and others added 6 commits April 28, 2021 20:10
The code to add a "back to top" link to the table of contents would fail with an error message on pages that don't have a TOC.
The link was also never added if the user started on a page without a TOC as the mkdocs-material instant loading feature prevents JS from being executed when navigating between local docs pages. This patch ensures the link is always added.
@ajstewart ajstewart requested a review from marxide April 29, 2021 18:37
@ajstewart ajstewart merged commit 0377d0c into dev Apr 29, 2021
@ajstewart ajstewart deleted the docs-lightgallery branch April 29, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants