-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor documentation improvements #487
Conversation
- Added dark mode to docs. - Added text about the .env file to documentation. - Clarified and made clearer the Django Q requirement for running jobs.
Looks good! I love the dark mode, but since it's unlabelled I only knew it was there because you mentioned it to me earlier. I wonder if changing the icon to the |
Co-authored-by: Andrew O'Brien <[email protected]>
This did cross my mind, I guess I have used so many dark modes now that I would be expecting that toggle to switch modes, there is also the hover info: The toggle is the default, the bundled options are: I do like the toggle as I like the minimalist approach, but I'd probably vote for the lightbulbs if we wanted more of a graphical representation? Though like you, I don't have that strong feelings on it. |
@marxide 7389173 bumps mkdocs-material to 7.1.1 minimum as I noticed dark mode wasn't working when I was on a lower version. I had a look to see what the other icons looked like but I still vote for the toggle in the end, simple because in my opinion, the icon indicates that it's something that can be toggled where as the other images don't really indicate that it's something that can be clicked. |
Includes the following improvements:
.env
file as I thought this was lacking.