discard the selavy unit row before reading #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this row was discarded after reading. Discarding it beforehand allows Pandas to better determine an appropriate default column dtype.
marxide
added
bug
ajstewart
previously approved these changes
Mar 17, 2021
One day I'll remember to do this before review...
|
Thanks, Adam. I forgot to update the change log again so I just pushed that. Merging without re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a problem with the way the pipeline currently reads in a modified Selavy catalogue. It's quite tricky to replicate the Selavy ASCII output format exactly, so I took some short cuts, namely filling the row of column units with dashes. I did this because the pipeline will always discard the second row (i.e. the first row after the column headers) anyway.
When loading this Selavy-like ASCII catalogue, every row has a dtype of object (string). This is mostly fine as we convert the columns to the proper dtypes defined in the Selavy translator. However, it's not fine for the has_siblings column since converting a string to bool will always result in
True.This doesn't happen with the original Selavy catalogues since the has_siblings column has no unit, so when Pandas parses the catalogue the has_sibling column contains only numbers.
This PR discards the Selavy unit row before reading the rest of the catalogue. Previously, this row was discarded after reading. Discarding it beforehand allows Pandas to better determine an appropriate default column dtype.