Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss445 CICD #446

Merged
merged 11 commits into from
Jan 12, 2021
Merged

Iss445 CICD #446

merged 11 commits into from
Jan 12, 2021

Conversation

dliptai
Copy link
Contributor

@dliptai dliptai commented Dec 22, 2020

Added a GitHub workflow to run the test suite.

  • Dev database is created using a Dockerfile + docker-compose (via a custom GitHub action)
  • Workflow is currently configured to run on pull requests only

@dliptai
Added workflow for running test suite
6a74603 
This includes a custom action "create-dev-database" which creates a development database using docker
@dliptai
Added test badge
308fa4d
@dliptai
Run workflow only on pull requests
0fdfc38
github-actions[bot]
github-actions bot reviewed Dec 22, 2020
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR: please assign the PR to a milestone, and to a reviewer if not auto-assigned. Add relevant labels if possible

@dliptai dliptai requested review from srggrs and ajstewart December 22, 2020 01:57
ajstewart
ajstewart requested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@ajstewart ajstewart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment below on the Postgres version. Other than that I think it looks good!

Also please update the CHANGELOG.md file with the changes.

@dliptai dliptai added the enhancement New feature or request label Dec 22, 2020
@dliptai dliptai linked an issue Dec 22, 2020 that may be closed by this pull request
Add test suite to GitHub actions #445
Closed
srggrs
srggrs reviewed Jan 10, 2021
View reviewed changes
Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Thank you for putting this together! At this stage my only question is why don't we dockerize the whole thing and use the image for both deployment and testing? I can picture we use essentially two containers (Pipeline + Postgres).

@srggrs srggrs added management management related things, e.g. github actions prod Nimbus Production Deployment testing A test that needs to be performed labels Jan 10, 2021
@dliptai dliptai requested review from ajstewart and srggrs January 11, 2021 02:47
srggrs
srggrs approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliptai dliptai merged commit b6a472c into master Jan 12, 2021
@dliptai dliptai deleted the iss445-CICD branch January 12, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ajstewart ajstewart ajstewart approved these changes

@srggrs srggrs srggrs approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request management management related things, e.g. github actions prod Nimbus Production Deployment testing A test that needs to be performed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test suite to GitHub actions
3 participants
@dliptai @ajstewart @srggrs