Updated alerts to use toasts #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait to see if @marxide has any solution for the Aladin z-index. |
|
I managed to track down the z-index bug, it was because the toast is shown inside the
So this is now ready to go. |
…m/askap-vast/vast-pipeline into issue-260-use-toast-notifications
srggrs
requested changes
Nov 25, 2020
CHANGELOG.md
Outdated
Comment on lines
124
to
128
| <<<<<<< HEAD | ||
| - [#408](https://github.com/askap-vast/vast-pipeline/pull/408) feat: use forced_phot dependency instead of copied code. | ||
| - [#407](https://github.com/askap-vast/vast-pipeline/pull/407) fix, model: modified 2-epoch metric calculation. | ||
| ======= | ||
| >>>>>>> 381c2a269ea04dba17bab187f4cf35a240949e7a |
There was a problem hiding this comment.
How did I miss that! I guess that's why I wait for reviews 😆 Fixed in e24ba16.
|
Merging with readme fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the alerts to use toasts instead, some screenshots:
Though I have one problem, the toast doesn't take z-index precedence over Aladin-lite (see screenshot) @marxide would you know how to solve this?:
Also I noticed the notifications don't appear on the
source_detail.htmltemplate unless the toasts script is explicitly loaded there. I imagine that this is why the alerts one was there in the first place, but I'm guessing this is also something to do with with Aladin or JS9 on this page?Fixes #260.