Bring new source checks inline with forced extraction. #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srggrs
previously approved these changes
Oct 11, 2020
Co-authored-by: Serg <[email protected]>
srggrs
previously approved these changes
Oct 12, 2020
srggrs
previously approved these changes
Oct 13, 2020
marxide
previously approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the new source checks inline with the same checks that are performed in the forced extraction. It will avoid inconsistencies between the two results like that seen in #207.
Also includes minor fix to the edge buffer application which was not being rounded before the int conversion.
Fixes #207.