Check all options are valid and present in validate_cfg #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the top of the config validation I've changed it such that the first thing that takes place is a check for:
I think it's good to enforce this as then the user shouldn't have any surprise settings that they weren't aware of if they somehow created their own config file.
This also avoids the issue in #365 where any not defined options needed later in the process are caught at the beginning and hence doesn't waste any time.
As this full check is now in place I have removed a few checks that were there checking for individual settings.
Fixes #365.