Add export and column visibility buttons to tables #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To note here that as nearly all the tables are server side these export buttons export what is currently on the page. I more see this as a convenience so I don't think we need to write our own fetching function to get all rows, especially as it could be nearly a million rows in some cases. Though the only place I see this as a problem is the sources query but I would rather direct users to the Jupyter Hub. |
* Added datatables-buttons extension. * Added jszip node dependency (for excel export). * Added Export to CSV and Excel buttons to tables. * Added Column visibility button. * Changed external search results page numbers. * Updated datatables to 1.10.22.
ajstewart
force-pushed
the
issue-360-add-tables-csv-export
branch
from
54dc9ee to
4c4beee
Compare
|
This can now be reviewed. Only change will be waiting for a Datatables-buttons release to fix the Excel export (if you want to test it the solution is in that linked issue). They say it's imminent... |
srggrs
reviewed
Oct 2, 2020
CHANGELOG.md
Outdated
Comment on lines
18
to
21
| - Added csv and excel export buttons to datatables on webinterface [#363](https://github.com/askap-vast/vast-pipeline/pull/363). | ||
| - Added column visibility button to datatables on webinterface [#363](https://github.com/askap-vast/vast-pipeline/pull/363). | ||
| - Added dependancy datatables-buttons 1.6.4 [#363](https://github.com/askap-vast/vast-pipeline/pull/363). | ||
| - Added dependancy jszip (required for Excel export) [#363](https://github.com/askap-vast/vast-pipeline/pull/363). |
There was a problem hiding this comment.
Gah, fixed in be4f81c.
marxide
requested changes
Oct 2, 2020
marxide
previously approved these changes
Oct 5, 2020
marxide
previously approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the Datatables buttons extension.
The
domwas defined using the solution presented here: https://stackoverflow.com/questions/32252616/datatable-styling-so-bootstrap-button-appears-on-same-row-as-other-elements.Excel will work when Datatables buttons makes a new release, see DataTables/Buttons#182.
This PR is based from #345 so will wait for that one to be done.
Some screenshots:
CSV exported from above:
Also reduces the pagination control numbers on the external results table to avoid overlap.
Fixes #360.
p.s. I couldn't work out how to ungroup the buttons, but the look grew on me.