Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth to GitHub org, add logging and docstring #333

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

srggrs
Copy link
Contributor

@srggrs srggrs commented Sep 11, 2020

Close #319

@srggrs srggrs requested a review from ajstewart September 11, 2020 06:43
@srggrs srggrs requested a review from marxide September 11, 2020 06:44
Copy link
Contributor

@marxide marxide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions for the type annotations. Otherwise, looks good!

@srggrs srggrs requested a review from marxide September 15, 2020 00:17
@srggrs srggrs merged commit 5f7123a into master Sep 16, 2020
@srggrs srggrs deleted the issue-319-github-org-login branch September 16, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change GitHub Login to Askap Org
3 participants