Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source detail page load hangs with many measurements #657

Closed
marxide opened this issue Apr 26, 2022 · 0 comments · Fixed by #658
Closed

Source detail page load hangs with many measurements #657

marxide opened this issue Apr 26, 2022 · 0 comments · Fixed by #658
Assignees
Labels
bug Something isn't working enhancement New feature or request UI User Interface

Comments

@marxide
Copy link
Contributor

marxide commented Apr 26, 2022

The source detail page for sources with many measurements (in this case over 3,000) does not finish loading. The bottleneck is most likely the generation of the measurement cutout images.

For cases like this, having all the cutouts displayed on the same page is unlikely to be useful. I propose we skip generating the cutouts for sources with more than some threshold of measurements, e.g. 30. This should be simple to do and won't take too much time to implement.

A better solution for future work could be to allow the user to specify which measurement they wish to render a cutout for, and then also render cutouts of some surrounding measurements. e.g. the user could identify a measurement of interest from the lightcurve and the cutout for this measurement will be rendered along with the 5 previous and 5 following measurement cutouts. By default, it could render the most significant or brightest measurement and adjacent measurements, or the top 10 most significant.

@marxide marxide added bug Something isn't working enhancement New feature or request UI User Interface labels Apr 26, 2022
@marxide marxide self-assigned this Apr 26, 2022
marxide added a commit that referenced this issue Apr 26, 2022
Truncates the number of displayed cutout images on the source detail page. Fixes #657.
[skip ci]
marxide added a commit that referenced this issue Apr 26, 2022
* added MAX_CUTOUT_IMAGES setting
Truncates the number of displayed cutout images on the source detail page. Fixes #657.

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request UI User Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant