Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed names (with positive sign) passed to NED #630

Closed
radioastronomer opened this issue Feb 23, 2022 · 1 comment · Fixed by #633
Closed

Malformed names (with positive sign) passed to NED #630

radioastronomer opened this issue Feb 23, 2022 · 1 comment · Fixed by #633

Comments

@radioastronomer
Copy link

Noticed from https://dev.pipeline.vast-survey.org/sources/5232259/
The links in the "External Search Results (1 arcmin)" are malformed
https://ned.ipac.caltech.edu/byname?objname=WISEA%20J120554.11+022625.5
should be
https://ned.ipac.caltech.edu/byname?objname=WISEA%20J120554.11%2B022625.5

This is likely an issue for other passes by name that include a positive sign.
@github-actions
Copy link
Contributor

Congrats on your first issue and Welcome to Askap pipeline development: please assign the issue to a milestone if not auto-assigned, and add relevant labels if possible

marxide added a commit that referenced this issue Feb 23, 2022
@marxide
URI encode NED object names
efc4c4a 
Fixes #630
[skip ci]
@marxide marxide mentioned this issue Feb 23, 2022
Merged
marxide added a commit that referenced this issue Feb 23, 2022
@marxide
URI encode NED object names (#633)
c49e1a6 
* URI encode NED object names
Fixes #630
[skip ci]

* updated changelog
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

URI encode NED object names askap-vast/vast-pipeline
1 participant
@radioastronomer