Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore run action not removing all necessary relations #579

Closed
ajstewart opened this issue Sep 9, 2021 · 0 comments · Fixed by #580
Closed

Restore run action not removing all necessary relations #579

ajstewart opened this issue Sep 9, 2021 · 0 comments · Fixed by #580
Assignees
@ajstewart
Labels
bug Something isn't working

Comments

@ajstewart
Copy link
Contributor

When images are added to a run it's possible that a relation is created between two sources that were not previously related. The restore run option is currently not taking this into account and is only removing relations between new sources from the added images.

Needs to remove remaining relations between remaining sources that were not related before the addition.
@ajstewart ajstewart added the bug Something isn't working label Sep 9, 2021
@ajstewart ajstewart self-assigned this Sep 9, 2021
ajstewart added a commit that referenced this issue Sep 9, 2021
@ajstewart
Added deletion and arrow files buttons
46b8397 
- Updated documentation.
- Fixed restore relations (#579).
@ajstewart ajstewart mentioned this issue Sep 9, 2021
Merged
@ajstewart ajstewart linked a pull request Sep 9, 2021 that will close this issue
Added UI run action buttons #580
Merged
ajstewart added a commit that referenced this issue Oct 8, 2021
@ajstewart
Added UI run action buttons (#580)
995590b 
* Added run restore button to UI

- Added restore api call in RunViewSet.
- Added hooks file for django-q async_task hooks.
- Added restore test.
- Fixed deprecation warning in test compare_runs.
- Added hooks.py to mkdocs.

* Fixed restore and run modal form id errors

* Switched async_task to call the command

- Makes calling the command from the website much easier.
- Removed hooks.
- Reverted the restorepiperun script.

* Added delete and generate arrow buttons

- Allowed for users to delete their runs.
- Allowed for users to generate arrow files for their run.
- Added new pipeline status of `DEL`, `Deleting`.

* Added deletion and arrow files buttons

- Updated documentation.
- Fixed restore relations (#579).

* Fix text and image spacing on doc page

[skip ci]

* Fix docs link in genarrow.md

[skip ci]

* Minor doc page fix pipeline job -> pipeline run

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajstewart ajstewart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added UI run action buttons askap-vast/vast-pipeline
1 participant
@ajstewart