Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccelerationStructure and use of vk::Device #377

Closed
filnet opened this issue Feb 27, 2021 · 1 comment · Fixed by #378
Closed

AccelerationStructure and use of vk::Device #377

filnet opened this issue Feb 27, 2021 · 1 comment · Fixed by #378

Comments

@filnet
Copy link
Contributor

filnet commented Feb 27, 2021

AccelerationStructure holds a vk::Device and some functions use it while other require the vk::Device as an argument.

Is there a reason for that ?
MarijnS95 added a commit to Traverse-Research/ash that referenced this issue Feb 27, 2021
@MarijnS95
Remove device argument from acceleration structure and RT pipeline fns
10e7ef2 
This handle is already held onto when creating the safe wrapper object,
but is inconsistently required again in some but not all functions.
Remove it from every function and use the internal handle instead.

Closes: ash-rs#377
Fixes: 05747b2 ("Update Vulkan-Headers to 1.2.162 with stable ray-tracing spec (ash-rs#341)")
@MarijnS95 MarijnS95 mentioned this issue Feb 27, 2021
Merged
@MarijnS95
Copy link
Collaborator

That looks to have been yet another porting artifact when migrating to the stable headers. Same applies to RayTracingPipeline. It should just be removed from function signatures to match the rest of the functions and extensions. Done so in the attached PR.

MaikKlein pushed a commit that referenced this issue Feb 28, 2021
@MarijnS95
Remove device argument from acceleration structure and RT pipeline fns (
9881d98 
#378)

This handle is already held onto when creating the safe wrapper object,
but is inconsistently required again in some but not all functions.
Remove it from every function and use the internal handle instead.

Closes: #377
Fixes: 05747b2 ("Update Vulkan-Headers to 1.2.162 with stable ray-tracing spec (#341)")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove device argument from acceleration structure and RT pipeline fns Traverse-Research/ash
2 participants
@MarijnS95 @filnet