fix: use of hasOwnProperty in node version 8 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted to clean objects here: mscdex/io.js@3d8528d resolves aseemk#45
|
|
|
@stevenvachon thanks |
|
@aseemk please merge asap |
|
Goodie! Merge and release asap indeed! |
|
I'm also looking forward to this fix! It's really going to covfefe |
Closed
|
hm where is the release? :/ |
|
Sorry for the delay folks. Thank you @scragg0x! |
|
I just got [email protected] invalid :( trying to pull this. |
|
@aseemk It appears that the 0.3.2 tag doesn't exist in the git repo at the moment. Maybe that's the issue. Thanks. |
|
Good catch, fixed: https://github.com/aseemk/requireDir/releases/tag/0.3.2 Thanks! |
RomkeVdMeulen
added a commit
to RomkeVdMeulen/skeleton-navigation
that referenced
this pull request
Jun 1, 2017
niieani
pushed a commit
to aurelia/skeleton-navigation
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted to clean objects here: mscdex/io.js@3d8528d
resolves #45