-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements - Bundler, front matter #24
Conversation
|
||
$ gem install jekyll-asciidoc` | ||
$ bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically the "install" part is not required. "install" is the default action for the bundle
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely agree, but in this case my intention was to make command line to be more 'self-explanatory', for instance for people not familiar with Bundler
.
Although, I can delete install
if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please choose what you feel is best. I was just pointing it out. It was only recently I learned this trick.
Thanks for updating the instructions! I added some comments inline with some suggested revisions. |
Fixed some of the issues, commented on others. |
Looks good! |
So, let's wait for @paulrayner to merge PR and then release 1.0.0 gem ? |
I propose some changes to make cleaner separation of plugin management and site building when using
Bundler