Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only register hooks once #120

Merged
merged 1 commit into from
Jul 4, 2016
Merged

only register hooks once #120

merged 1 commit into from
Jul 4, 2016

Conversation

mojavelinux
Copy link
Member

@mojavelinux mojavelinux commented Jul 4, 2016 •
edited
Loading

  • only register callbacks for pre_render and post_render hooks once
  • register callbacks as static methods so they work on any site instance
  • add test to ensure hook callbacks are only registered once

@mojavelinux mojavelinux force-pushed the register-hooks-once branch from c33470a to 67aa6f3 Compare July 4, 2016 05:50
@mojavelinux
only register hooks once
2244936 
- only register callbacks for pre_render and post_render hooks once
- register callbacks as static methods so they work on any site instance
- add test to ensure hook callbacks are only registered once
@mojavelinux mojavelinux force-pushed the register-hooks-once branch from 67aa6f3 to 2244936 Compare July 4, 2016 08:13
@mojavelinux mojavelinux merged commit 93fc608 into asciidoctor:master Jul 4, 2016
@mojavelinux mojavelinux deleted the register-hooks-once branch July 4, 2016 08:22
@mojavelinux mojavelinux mentioned this pull request Jul 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mojavelinux