Skip to content
This repository was archived by the owner on Dec 28, 2022. It is now read-only.

feat: add mark support #128

Merged
merged 2 commits into from
May 20, 2016
Merged

feat: add mark support #128

merged 2 commits into from
May 20, 2016

Conversation

ldez
Copy link
Member

@ldez ldez commented May 16, 2016

Description

http://asciidoctor.org/docs/user-manual/#custom-styling-with-attributes

Syntax example

.foobar
[role]**foo** bar
[role]*foo* bar
[role]__foo__ bar
[role]_foo_ bar
[role]##foo## bar
[role role2]#foo# bar
[role]``foo`` bar
[role]`foo` bar
[role]^foo^bar^foo^bar
[role]~foo~bar~foo~bar

Screenshots

capture du 2016-05-16 21-55-19

@mojavelinux
Copy link
Member

Nice job!

Mark without a role becomes the mark element in HTML, which appears as highlighted text. Would it be possible to style it that way in the theme? (basically by reversing the background and foreground colors).

@ldez
Copy link
Member Author

ldez commented May 16, 2016

Like that ? 😄

capture du 2016-05-16 23-44-49

[role role2]##foo## bar
[.role#id]##foo## bar
##foo## bar
#foo# bar

@mojavelinux
Copy link
Member

Yes! \o/

@ldez ldez force-pushed the feature/mark branch 3 times, most recently from 71b9c75 to 99260cf Compare May 18, 2016 19:27
@mojavelinux
Copy link
Member

I think we're in good shape. @nicorikken, what say you?

@nicorikken
Copy link
Contributor

Somehow I haven't been able to get the highlight to work under my theme. But syntax highlighting looks good. LGTM!

@ldez
Copy link
Member Author

ldez commented May 20, 2016

I have try with different themes, which theme are you using ?

@nicorikken
Copy link
Contributor

I tried Seti, Atom One Dark, Atom One Light.

@ldez
Copy link
Member Author

ldez commented May 20, 2016

one-dark:
one-dark

one-light:
one-light

seti:
seti

@ldez ldez merged commit ee0f301 into asciidoctor:master May 20, 2016
@ldez ldez deleted the feature/mark branch May 20, 2016 19:01
@nicorikken
Copy link
Contributor

Apparently I did not check with the latest code. Now it does work properly 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants