Remove deprecated from Asciidoctor interface #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-1201-remove-deprecated-from-Asciidoctor-interface
branch
from
2b96db9 to
5b20ad4
Compare
|
@mojavelinux I am documenting on the migration guide how to use |
abelsromero
force-pushed
the
issue-1201-remove-deprecated-from-Asciidoctor-interface
branch
from
5b20ad4 to
9241818
Compare
abelsromero
force-pushed
the
issue-1201-remove-deprecated-from-Asciidoctor-interface
branch
from
9241818 to
fbd2838
Compare
* Also remove class org.asciidoctor.ast.DocumentHeader * Update changelog Fixes asciidoctor#1201
|
Rebased from main, ready for review 🎉 |
|
Thanks! |
abelsromero
deleted the
issue-1201-remove-deprecated-from-Asciidoctor-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
org.asciidoctor.Asciidoctorinterface to streamline API.Just methods using
org.asciidoctor.Optionsremain now.readDocumentHeadermethods andorg.asciidoctor.ast.DocumentHeaderclassHow does it achieve that?
Simply remove the methods and refactor the required code.
Special mention to
WhenDocumentHeaderIsRequiredtest, we could remove it, but I just reimplemented with the new API to ensure users can still obtain the same information.Are there any alternative ways to implement this?
No, it's only remove, no changes in the methods lefts.
Are there any implications of this pull request? Anything a user must know?
It's breaking for v3.0.0 but we add a migration guide to help.
Issue
Fixes #1201
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc