Use junit-pioneer to simplify polluted tests #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-1193-use-junit-pioneer-to-simplify-polluted-tests
branch
from
61f1a53 to
fbc6ff9
Compare
|
I added the missing Asciidoctor Factory cases and asserted them based on the returned values. @robertpanzer cpould you please double-check nothing is wrong? |
|
"drafting" while I look into the test that failed 😞 |
abelsromero
force-pushed
the
issue-1193-use-junit-pioneer-to-simplify-polluted-tests
branch
from
fbc6ff9 to
0e5b661
Compare
* Add junit-pioneer to inject environment variables into tests. This allows removing custom Gradle task pollutedTest and running them normally. * Refactor WhenAnAsciidoctorClassIsInstantiatedInAnEnvironmentWithGemPath as a parametrized tests. * Add missing cases for Asciidoctor Factory in WhenAnAsciidoctorClassIsInstantiatedInAnEnvironmentWithGemPath. Fixes asciidoctor#1193
|
I had to apply a workaround for Windows builds only to set |
|
Thanks! 👍 |
abelsromero
deleted the
issue-1193-use-junit-pioneer-to-simplify-polluted-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Simplify Gradle build and fix some IDE integration issues. See #1193 for details.
How does it achieve that?
Are there any alternative ways to implement this?
Discussed in #1193.
Are there any implications of this pull request? Anything a user must know?
No, if anything, it should be easier for contributors now.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1193
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc