Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set data-fragment-index on elements #241

Closed
fiddlededee opened this issue Feb 13, 2019 · 3 comments · Fixed by #383
Closed

set data-fragment-index on elements #241

fiddlededee opened this issue Feb 13, 2019 · 3 comments · Fixed by #383

Comments

@fiddlededee
Copy link

It would be great to have possibility to set data-fragment-index on an element. This could allow to make simultaneous appearence or disappearence or whatever else of several elements.

This issue asciidoctor/asciidoctor#1305 would solve the problem, but it is not implemented yet.

General solution could look like:

[.fragment.highlight-red, data-fragment-index=1]#text1#
[.fragment.highlight-red, data-fragment-index=0]#text2#
[.fragment.highlight-red, data-fragment-index=1]#text3#

On the 1st step we get text2 turning red, on the second -- text1 and text3 turning red.

@obilodeau
Copy link
Member

Interesting idea! I anticipate it would be straight forward to implement too.

We need to release 2.0 first so I'll tag it for 2.1. If someone PRs this before we release we will review and accept. Contributions welcome!

@obilodeau obilodeau added this to the 2.1.0 milestone Feb 13, 2019
@mojavelinux
Copy link
Member

FYI, solving asciidoctor/asciidoctor#1305 wouldn't solve the problem for this converter since the implementation is specific to the converter. In other words, the reveal converter can implement passthrough support for data- attributes today without waiting for core. It's a converter concern. All user-defined attributes are available via the API.

@ebousse
Copy link

ebousse commented Sep 4, 2019

This feature would indeed be great! :)

ggrossetie added a commit to ggrossetie/asciidoctor-reveal.js that referenced this issue Nov 5, 2020
ggrossetie added a commit to ggrossetie/asciidoctor-reveal.js that referenced this issue Nov 27, 2020
@mojavelinux mojavelinux changed the title settomg data-fragment-index on elements set data-fragment-index on elements Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants